Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wakeup light in 256 steps #9241

Closed
jesseruiter opened this issue Sep 5, 2020 · 12 comments · Fixed by #9391
Closed

Wakeup light in 256 steps #9241

jesseruiter opened this issue Sep 5, 2020 · 12 comments · Fixed by #9391
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended

Comments

@jesseruiter
Copy link

Have you looked for this feature in other issues and in the docs?
yes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
When the wakeup command is called, the light is still quite bright at the start and the fading isn't very smooth.

Describe the solution you'd like
A clear and concise description of what you want to happen.
When the wakeup command uses 256 (instead of 100) steps the fading will be smoother and I don't wake up directly when the value is 1%😁

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I can't come up with an alternative solution.

Additional context
Add any other context or screenshots about the feature request here.
Not needed.

(Please, remember to close the issue when the problem has been addressed)

@s-hadinger
Copy link
Collaborator

Please give more details about your setup. What kind of light are you using (pwm?) and did you enable gamma correction with LedTable 1?

@ascillato2 ascillato2 added the question Type - Asking for Information label Sep 5, 2020
@jesseruiter
Copy link
Author

I am using a 5050 SMD LED Strip in combination with a Magic Home controller. I don't use gamma correction, as LedTable == 0.

@jesseruiter
Copy link
Author

However, I don't think it depends on my setup, but on the way the wakeup function is implemented. Right now the least bright is 1 percent (so 1/100) instead of the possible 1/256. The latter would result in a smoother wakeup pattern.

@s-hadinger
Copy link
Collaborator

Then I believe that you should enable Gamma Correction, otherwise the brightness goes very quickly to a high perceived value.

@jesseruiter
Copy link
Author

I tried that function, but then my brightness of my led strip isn't lineair anymore and the initial brightness is still 1/100 instead of the possible 1/256. I think this issue is therefore a feature request, instead of a question.

@ascillato
Copy link
Contributor

Hi,

Have you tried LedTable 1?

@jesseruiter
Copy link
Author

Yes I did, but that made the smoothness of the LED strip's brightness worse.

@jesseruiter
Copy link
Author

I tried that function, but then my brightness of my led strip isn't lineair anymore and the initial brightness is still 1/100 instead of the possible 1/256. I think this issue is therefore a feature request, instead of a question.

But as said here, it is not so much a problem, but more a suggestion to smoothen the wake up pattern. Because I use the LED strip with the wakeup function as a wakeup light divided over 20 minutes, the experience would be better if the brightness is incremented 1/256 every ~5 seconds, instead of an increase of 1/100 every 12 seconds.

@ascillato2
Copy link
Collaborator

ascillato2 commented Sep 22, 2020

LED strip with the wakeup function as a "wakeup light" divided over 20 minutes

Ok. With that time frame you need a higher resolution. With smaller time frames the 100 steps are smooth enough.

Changing to feature request. Thanks for explaining your use-case.

@ascillato2 ascillato2 added feature request (devs?) Action - awaiting response from developers and removed question Type - Asking for Information labels Sep 22, 2020
@s-hadinger
Copy link
Collaborator

@jesseruiter I completely agree with you. When you use Gamma Correction LedTable 1 it doesn't really make a difference because the first steps are very distant from each other and splitting in 256 wouldn't make a difference.

I don't have time in the short term to change this, but it shouldn't be a big change to the code, although we need to adjust the duration if it's 256 steps instead of 100.

@jesseruiter
Copy link
Author

Thanks for your reaction! I look forward to the update sometime in the future.

@s-hadinger
Copy link
Collaborator

Oops, I observed a crash... Not ready

arendst added a commit that referenced this issue Sep 26, 2020
Change ``WakeUp`` uses 256 steps instead of 100 (#9241)
@ascillato2 ascillato2 added enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended and removed feature request (devs?) Action - awaiting response from developers labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants