Can't compile with USE_MQTT_TLS

[poofyteddy]

PROBLEM DESCRIPTION

A clear and concise description of what the problem is.
Error while compiling

Repo/tasmota/xdrv_02_mqtt.ino:804:168: error: operands to ?: have different types 'int' and 'char*'
       strlcpy(fingerprint, (SC_CLEAR == Shortcut()) ? "" : (SC_DEFAULT == Shortcut()) ? (1 == XdrvMailbox.index) ? MQTT_FINGERPRINT1 : MQTT_FINGERPRINT2 : XdrvMailbox.data, sizeof(fingerprint));

with #define USE_MQTT_TLS in user_config_override.h

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

• [] Read the Contributing Guide and Policy and the Code of Conduct
• [] Searched the problem in issues
• Searched the problem in the docs
• Searched the problem in the forum
• Searched the problem in the chat
• Device used (e.g., Sonoff Basic): _____
• Tasmota binary firmware version number used: latest dev
  • Pre-compiled
  • Self-compiled
    • IDE / Compiler used: Vscode platformio
• Flashing tools used: _____
• Provide the output of command: Backlog Template; Module; GPIO 255:

  Configuration output here:

• If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:

  Rules output here:

• Provide the output of this command: Status 0:

  STATUS 0 output here:

• Provide the output of the Console log output when you experience your issue; if applicable:
  (Please use weblog 4 for more debug information)

  Console output here:

TO REPRODUCE

Steps to reproduce the behavior:
#define USE_MQTT_TLS
compile env:tasmota

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

[arendst]

As the compile error message tries to explain the fingerprint types have changed. That happend the day before yesterday. See changelog and my_user_config.h what you need to do to make compile possible again.

[s-hadinger]

I realize we don't have a channel to announce breaking changes in the code.

#9570 changed the format for compile time fingerprints, which has the side effect of saving 232 bytes for all Tasmota versions, even the ones that will never use TLS nor fingerprints.

[poofyteddy]

i am sorry but i am not quite sure i understand :(
I don't override MQTT_FINGERPRINT(1-2), and my my_user_config.h is the one from the repo

#define MQTT_FINGERPRINT1      0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00  // [MqttFingerprint1] (auto-learn)
#define MQTT_FINGERPRINT2      0xDA,0x39,0xA3,0xEE,0x5E,0x6B,0x4B,0x0D,0x32,0x55,0xBF,0xEF,0x95,0x60,0x18,0x90,0xAF,0xD8,0x07,0x09  // [MqttFingerprint2] (invalid)

The change log say #define MQTT_FINGERPRINT from string to hexnumbers (#9570) and as far as i know, what is above isn't a string (no quote)

I am obviously missing something very simple, but can't get what ....

[s-hadinger]

Oh sorry, you are right. Let me revisit this part.

[poofyteddy]

Thank you for the fix :)