Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code size for fingerprint #9570

Merged
merged 1 commit into from Oct 19, 2020

Conversation

s-hadinger
Copy link
Collaborator

Description:

Reduce Flash size by 232 bytes for all Tasmota versions.
The default settings used a parser for fingerprint which is a pity for a very rarely used feature. Replaced with a simple memcpy.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.3
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit a13bb77 into arendst:development Oct 19, 2020
arendst added a commit that referenced this pull request Oct 19, 2020
Change ``#define MQTT_FINGERPRINT`` from string to hexnumbers (#9570)
@s-hadinger s-hadinger mentioned this pull request Oct 20, 2020
13 tasks
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants