Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HaTasmota update #9727

Merged
merged 2 commits into from
Nov 3, 2020
Merged

HaTasmota update #9727

merged 2 commits into from
Nov 3, 2020

Conversation

effelle
Copy link
Contributor

@effelle effelle commented Nov 3, 2020

Description:

Update to grab latest changes in Switch.ino.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.5
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Nov 3, 2020

Thx. Is there another means of direct contacting you? If so just email me how.

@arendst
Copy link
Owner

arendst commented Nov 3, 2020

Compile error at line 288:

    if (i == 0 && (SONOFF_DUAL == TasmotaGlobal.module_type )) { SerialButton = true; }

i was never declared.

Repository owner deleted a comment from effelle Nov 3, 2020
@arendst arendst merged commit ee88451 into arendst:development Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants