Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jcasbin #111

Merged
merged 4 commits into from
Mar 13, 2023
Merged

feat: support jcasbin #111

merged 4 commits into from
Mar 13, 2023

Conversation

lucas-myx
Copy link
Collaborator

#85

@lucas-myx lucas-myx added the enhancement ⭐ New feature or request label Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #111 (d1eff66) into main (7c0308f) will increase coverage by 0.53%.
The diff coverage is 83.50%.

@@             Coverage Diff              @@
##               main     #111      +/-   ##
============================================
+ Coverage     34.73%   35.26%   +0.53%     
- Complexity      803      835      +32     
============================================
  Files           191      197       +6     
  Lines          7445     7523      +78     
  Branches        812      820       +8     
============================================
+ Hits           2586     2653      +67     
- Misses         4595     4603       +8     
- Partials        264      267       +3     
Impacted Files Coverage Δ
.../springsecurity/SpringSecurityInstrumentation.java 68.75% <0.00%> (-7.45%) ⬇️
...ava/io/arex/inst/httpservlet/ServletExtractor.java 95.45% <0.00%> (ø)
...inst/httpservlet/inst/FilterInstrumentationV3.java 72.22% <72.22%> (ø)
...inst/httpservlet/inst/FilterInstrumentationV5.java 72.22% <72.22%> (ø)
...authentication/jcasbin/JCasbinInstrumentation.java 80.00% <80.00%> (ø)
.../io/arex/inst/httpservlet/ServletAdviceHelper.java 93.81% <85.71%> (-1.43%) ⬇️
...tication/jcasbin/JCasbinModuleInstrumentation.java 100.00% <100.00%> (ø)
...nst/authentication/shiro/ShiroInstrumentation.java 81.81% <100.00%> (+13.06%) ⬆️
...httpservlet/adapter/impl/ServletAdapterImplV3.java 97.82% <100.00%> (+0.60%) ⬆️
...httpservlet/adapter/impl/ServletAdapterImplV5.java 97.82% <100.00%> (+0.60%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

85.7% 85.7% Coverage
6.5% 6.5% Duplication

@lucas-myx lucas-myx marked this pull request as ready for review March 13, 2023 12:18
@lucas-myx lucas-myx merged commit 58090ea into main Mar 13, 2023
@lucas-myx lucas-myx deleted the feat-jcasbin branch March 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⭐ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants