-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dynamic retransform #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
============================================
+ Coverage 52.42% 53.04% +0.62%
- Complexity 1416 1479 +63
============================================
Files 222 224 +2
Lines 8450 8547 +97
Branches 999 1018 +19
============================================
+ Hits 4430 4534 +104
+ Misses 3599 3589 -10
- Partials 421 424 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
YongwuHe
force-pushed
the
feature/restransform
branch
10 times, most recently
from
May 15, 2023 11:24
f96a59d
to
a923794
Compare
mr3
force-pushed
the
feature/restransform
branch
7 times, most recently
from
June 5, 2023 08:32
4fc29bf
to
b9909ae
Compare
mr3
force-pushed
the
feature/restransform
branch
3 times, most recently
from
June 5, 2023 13:41
844884f
to
0bceb08
Compare
mr3
force-pushed
the
feature/restransform
branch
5 times, most recently
from
June 6, 2023 12:29
874ddc1
to
89c53de
Compare
lucas-myx
previously approved these changes
Jun 7, 2023
Kudos, SonarCloud Quality Gate passed! |
mr3
approved these changes
Jun 9, 2023
lucas-myx
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resTransform(Set<?> resetClasses, List<?> reTransformClasses)
resetClasses means that the classes in it no longer need to be modified in the new configuration, directly reset this class.
reTransformClasses represents that the modification methods of the classes in it have changed, and these classes need to be re-transform.
1.addNewClass
old dynamic config : classA methodA
new dynamic config : classA methodA, classB methodB
resetClasses = empty, reTransformClasses = [classB]
2.deleteClass
old dynamic config : classA methodA, classB methodB
new dynamic config : classA methodA
resetClasses = [classB], reTransformClasses = empty
3.existing class add method
old dynamic config : classA methodA
new dynamic config : classA methodA, classA methodB
resetClasses = empty, reTransformClasses = [classA methodA, classA methodB]
4.existing class delete method
old dynamic config : classA methodA, classA methodA2
new dynamic config : classA methodA,
resetClasses = empty, reTransformClasses = [classA methodA]
5.existing class add method and delete class
old dynamic config : classA methodA, classB methodB
new dynamic config : classA methodA, classA methodA2
resetClasses = [classB ], reTransformClasses = [classA methodA, classA methodA2]