Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record servlet request redirect #161

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: record servlet request redirect #161

merged 1 commit into from
May 16, 2023

Conversation

mr3
Copy link
Collaborator

@mr3 mr3 commented May 10, 2023

Fix: #51

  1. Store the original url to context when response returns 302
  2. Change sendRedirect method to pass arex-record-id of the original request
  3. Save recorded data base on request type: redirect or not

@mr3 mr3 added the bug 🐞 Something isn't working label May 10, 2023
@mr3 mr3 marked this pull request as draft May 10, 2023 13:46
@mr3 mr3 force-pushed the feature/redirect branch 4 times, most recently from 8173f35 to 3b13b99 Compare May 15, 2023 13:38
@mr3 mr3 marked this pull request as ready for review May 15, 2023 13:39
@mr3 mr3 force-pushed the feature/redirect branch 4 times, most recently from 3095a1b to 731934c Compare May 15, 2023 14:58
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #161 (bc31609) into main (0af26e2) will increase coverage by 0.08%.
The diff coverage is 62.09%.

@@             Coverage Diff              @@
##               main     #161      +/-   ##
============================================
+ Coverage     48.18%   48.26%   +0.08%     
- Complexity     1257     1280      +23     
============================================
  Files           212      213       +1     
  Lines          8215     8318     +103     
  Branches        943      965      +22     
============================================
+ Hits           3958     4015      +57     
- Misses         3870     3915      +45     
- Partials        387      388       +1     
Impacted Files Coverage Δ
...ain/java/io/arex/agent/bootstrap/model/Mocker.java 0.00% <0.00%> (ø)
...a/io/arex/inst/runtime/context/ContextManager.java 39.47% <0.00%> (-1.07%) ⬇️
...main/java/io/arex/inst/runtime/util/MockUtils.java 0.00% <0.00%> (ø)
...arex/foundation/services/DataCollectorService.java 0.00% <ø> (ø)
...tpservlet/wrapper/CachedBodyResponseWrapperV3.java 7.95% <0.00%> (-0.29%) ⬇️
...tpservlet/wrapper/CachedBodyResponseWrapperV5.java 7.86% <0.00%> (-0.28%) ⬇️
...java/io/arex/inst/runtime/context/ArexContext.java 26.92% <9.09%> (-17.91%) ⬇️
.../io/arex/inst/httpservlet/ServletAdviceHelper.java 92.23% <86.36%> (-2.72%) ⬇️
...ain/java/io/arex/inst/httpservlet/ServletUtil.java 88.23% <88.23%> (ø)
...ava/io/arex/inst/httpservlet/ServletExtractor.java 97.53% <100.00%> (+2.07%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr3 mr3 force-pushed the feature/redirect branch 2 times, most recently from 96c9a6c to ba28b81 Compare May 16, 2023 03:14
YongwuHe
YongwuHe previously approved these changes May 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.9% 87.9% Coverage
19.0% 19.0% Duplication

@mr3 mr3 merged commit f3bc388 into main May 16, 2023
9 of 10 checks passed
@mr3 mr3 deleted the feature/redirect branch May 16, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
3 participants