Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert observer options to bit field #25

Merged
merged 126 commits into from
Sep 7, 2018

Conversation

realityforge
Copy link
Member

No description provided.

The API is still based around old parameter style
…ent if `Arez.areSpiesEnabled()` returns false.
…methods and the `ArezContext.computed(...)` methods
@codecov-io
Copy link

codecov-io commented Sep 7, 2018

Codecov Report

Merging #25 into master will decrease coverage by 0.23%.
The diff coverage is 87.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #25      +/-   ##
===========================================
- Coverage     91.03%   90.8%   -0.24%     
- Complexity     3025    3037      +12     
===========================================
  Files            92      90       -2     
  Lines          7238    7219      -19     
  Branches       1179    1181       +2     
===========================================
- Hits           6589    6555      -34     
- Misses          111     119       +8     
- Partials        538     545       +7
Impacted Files Coverage Δ Complexity Δ
.../main/java/arez/processor/ComponentDescriptor.java 96.57% <ø> (ø) 625 <0> (ø) ⬇️
core/src/main/java/arez/Node.java 83.33% <ø> (+4.16%) 24 <0> (+1) ⬆️
...e/src/main/java/arez/spy/ObserverCreatedEvent.java 100% <100%> (ø) 3 <1> (-1) ⬇️
core/src/main/java/arez/Component.java 82.4% <100%> (ø) 65 <0> (ø) ⬇️
...re/src/main/java/arez/spy/ComputeStartedEvent.java 100% <100%> (ø) 3 <1> (-1) ⬇️
core/src/main/java/arez/SpyImpl.java 88.46% <100%> (+6.31%) 36 <3> (-55) ⬇️
...ain/java/arez/spy/ObservableValueChangedEvent.java 90.9% <100%> (-0.76%) 4 <1> (-1)
...in/java/arez/spy/ObservableValueDisposedEvent.java 100% <100%> (ø) 3 <1> (-1) ⬇️
.../main/java/arez/spy/ComputedValueCreatedEvent.java 100% <100%> (ø) 3 <1> (-1) ⬇️
...ore/src/main/java/arez/spy/ActionStartedEvent.java 100% <100%> (ø) 5 <1> (-1) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bcb01...ee8af62. Read the comment docs.

@realityforge realityforge merged commit fb65896 into master Sep 7, 2018
@realityforge realityforge deleted the ConvertObserverOptionsToBitField branch September 7, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants