-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rhys to the website #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rhys, thanks for the PR. Excited to see you're joining the group. I have one minor comment about your profile, but everything else looks good.
Once you have addressed my comment, I'd be happy to re-review this PR.
_data/people.yml
Outdated
pic: /img/people/macmillanr.png | ||
dates: 2024-Present | ||
role: Undergraduate Research Assistant | ||
description: 'Ideal ARFC group members seek to advance nuclear energy challenges through advanced computing, physics-informed modeling, and sophisticated simulation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider taking a look at what other members of the group have written in the description field, it looks like this is the description from the generic group member template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RhysMacMillan Nathan's comment here is great! Would you mind updating this description to reflect you, rather than ARFC in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in the brief bio, everything looks good to me (LGTM)! I took care of the merge conflicts.
Summary of changes
This pull request adds Rhys's photo and website bio information.
Types of changes
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.