Updates Serpent models #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfairh
requested review from
gwenchee,
ZoeRichter,
mehmeturkmen,
smpark7 and
abachma2
robfairh
added
Comp:Core
abachma2
reviewed
Nov 13, 2020
serpent/compact
Outdated
Comment on lines
11
to
15
| * Kernel radius 2.125e-6 cm * | ||
| * Buffer radius 3.125e-6 cm * | ||
| * IPyC radius 3.475e-6 cm * | ||
| * SiC radius 3.825e-6 cm * | ||
| * OPyC radius 4.225e-6 cm * |
There was a problem hiding this comment.
Are these just unit conversions?
There was a problem hiding this comment.
Yes. This is just a comment though, it doesn't affect the simulation
| "wo16: 0.0897065977520648\n", | ||
| "wc12: 0.0224266494380162\n", | ||
| "\n", | ||
| "Nu235: 0.0036633202990892723\n", |
There was a problem hiding this comment.
What exactly are the N values? The number density?
serpent/compact
Outdated
Comment on lines
11
to
15
| * Kernel radius 212.5e-6 m * | ||
| * Buffer radius 312.5e-6 m * | ||
| * IPyC radius 347.5e-6 m * | ||
| * SiC radius 382.5e-6 m * | ||
| * OPyC radius 422.5e-6 m * | ||
| * Kernel radius 2.125e-6 cm * | ||
| * Buffer radius 3.125e-6 cm * | ||
| * IPyC radius 3.475e-6 cm * | ||
| * SiC radius 3.825e-6 cm * | ||
| * OPyC radius 4.225e-6 cm * |
There was a problem hiding this comment.
Are these just unit conversions?
There was a problem hiding this comment.
Yes. This is just a comment though, it doesn't affect the simulation
| @@ -17,7 +17,6 @@ | |||
| * OPyC radius 422.5e-6 m * | |||
| * Matrix Graphite * | |||
There was a problem hiding this comment.
Did you also want to reflect the unit conversions here?
There was a problem hiding this comment.
yes, I just fixed all the unit conversions. They were all wrong ...
abachma2
approved these changes
Nov 13, 2020
This was referenced Nov 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24, #26, and #27.
This PR additionally defines an input file for a fuel column with lumped burnable poisons.
And it also adds a jupyter notebook with the material composition calculation.