Completely refactored and changed after latest Teddy's release (0.2.0)

[andrewryh]

Summary of changes

Saltproc after refactoring, implementing non-ideal poison removal, adjustable geometry, variable depletion step. Also introduces documentation, CITATION document

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

Associated Issues and PRs

• Issue: Set up continuous integration for salt proc #26 Add docs to continuous integration #35 The tap_main.json example file fails to run due to filepath issues. #38
• PR: Generated with Sphinx documentation added to make it available to users. #36

Associated Developers

• Dev: @andrewryh @katyhuff

[andrewryh]

2. Remove random commented code from all files in saltproc/data directory

Done! Commit 4784239

3. Make all python files pep8 compatible

They are! PEP8 did not find any issues. Surround top-level function and class definitions with two blank lines. See here: https://www.python.org/dev/peps/pep-0008/

4. Add documentation for all python test_* functions.

Good idea! See issue #39. This is not very sensitive problem, so, I going to do it later.

[smpark7]

After the latest commits, the saltproc example and tests ran successfully on my machine.

[andrewryh]

@gwenchee I addressed most of your comments. Please, check it out.

[gwenchee]

Looks good to me! Good job shortening the README

[andrewryh]

Looks good to me! Good job shortening the README

Thank you!

We all will take another look during the review meeting on Wed, Feb 5th, 2-4 pm, and, hopefully, will merge it!

Thank you, everyone, for your effort!