Modified creation of cyclus input from PRIS data #115
Conversation
|
Hello @abachma2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-01-13 00:04:46 UTC |
abachma2
requested review from
gwenchee,
LukeSeifert,
robfairh,
samgdotson and
yardasol
There was a problem hiding this comment.
I've never used cyclus, so my comments are from the perspective of an outsider-ish.
My two thoughts are:
- Templates should be maximally flexible. (This is really an opinion)
- Magic numbers should not exist without very good reason (and then they're usually not magic numbers).
| @@ -63,14 +63,14 @@ | |||
| </recipe> | |||
| <recipe> | |||
| <name>cool_spent_uox</name> | |||
| <basis>atom</basis> | |||
| <basis>mass</basis> | |||
There was a problem hiding this comment.
This seems like something that should be user specified.
E.g. allow for options when running create_input.py like
python create_input.py -a # for atom basis
pyhton create_input.py -m # for mass basis
There was a problem hiding this comment.
As long as the IAEA PRIS database is on a mass basis, this is fine. @abachma2 feel free to resolve this conversation if that's the case.
There was a problem hiding this comment.
The recipe data doesn't come from PRIS. It comes from the vision recipes in database/vision_recipes/. I don't know where that data came from originally.
|
Thanks for the comments @samgdotson. I made most of the changes to reflect the current structure of the raw data from PRIS. I can try to modify it to match column names as opposed to numbers, allowing for some flexibility if the raw data changes format. |
|
I changed some of the data containers to pandas DataFrames from lists. This should remove need for 'magic numbers' |
| @@ -63,14 +63,14 @@ | |||
| </recipe> | |||
| <recipe> | |||
| <name>cool_spent_uox</name> | |||
| <basis>atom</basis> | |||
| <basis>mass</basis> | |||
There was a problem hiding this comment.
As long as the IAEA PRIS database is on a mass basis, this is fine. @abachma2 feel free to resolve this conversation if that's the case.
|
Made two minor comments. When handled, I approve. |
|
Merged! |
I made changes to facilitate the creation of cyclus input files using data from the PRIS Year-end Report.
scripts/predicting-the-past-import.pywas modified to reflect the structure of the raw data from PRIS, when saved as a.csv.scripts/create_input.pywas created to perform the actions to create the input file, mirroring what is ininputs/predicting-the-past/united_states.ipynb.