Мigrate to truffle

[elenadimitrova]

Here we migrate the solution from etherlime to the truffle framework. Truffle is used for compilation (using docker), testing, deployment and its extensions framework additionally implements code coverage, gas cost testing and etherscan verification.

Notable changes include

• Using bn.js consistently for comparing and working with big numbers
• Network ganache is now named development, note that configuration file has changed from ganache.json to development.json
• The deployer role is now minimal and it's no longer required to deploy new instances of a contract or create references to existing contracts. e.g. deployer.deploy(GuardianStorage) becomes GuardianStorage.new() and deployer.wrapDeployedContract(ENS, newConfig.ENS.ensRegistry) becomes ENS.at(newConfig.ENS.ensRegistry).
• verboseWaitForTransaction is no longer required as the transaction receipt is returned directly for each contract call.
• .contractAddress becomes .address
• Contracts loading from outside the build folder is done via @truffle\contract until Allow artifacts loading from outside contracts and test folders trufflesuite/truffle#3436 is resolved

Plugins used

• Gas reports using eth-gas-reporter and CodeChecks
  https://github.com/argentlabs/argent-contracts/pull/146/checks?check_run_id=1341683785

These reports differ to the benchmark script results in that gas consumption per method is given which doesn't take into consideration chained calls though Proxy and/or Relayer contracts (meta transactions). We could accept these instances as relayed transactions take on average the same amount of extra gas ~45,000 while the Proxy calls are relevant only for the BaseWallet calls which are minimal.

• Code coverage running via a plugin developed by @cgewecke in Add coverage script for truffle experiment #177 ref Support for multiple truffle configs compilation sc-forks/solidity-coverage#559

• Etherscan verification using truffle-plugin-verify ref Fails to verify Argent contracts rkalis/truffle-plugin-verify#46
  This is done explicitly via the ./scripts/verify.js script which verifies in EtherScan all contracts from the configuration file's "contracts" and "modules" sections for the test, staging and production networks.

blockers

• Async provider factory in truffle config Provider factory in truffle config should be able to operate asynchronously trufflesuite/truffle#1054
• Improve performance high cpu and memory usage trufflesuite/truffle#3509 (comment)

nice-to-haves

• Upgrade to latest truffle chore: move chain packages to a subfolder (temp) trufflesuite/ganache#702
• Enable getting the chainId in utilities.getChainId() after Upgrading Web3 >= 1.2.2 trufflesuite/truffle#2688 is resolved

[juniset]

Shouldn't it be ContractWrapper = await Contract.at(config...) instead of using ContractWrapper = await Contract.new(config...)?

[elenadimitrova]

Yes, thanks, updated.

[olivdb]

FYI we used to have a custom AWSWalletProvider to solve that issue https://github.com/argentlabs/solidity/blob/dev/truffle-awswallet-provider/index.js

[elenadimitrova]

I'll add a card to investigate that if the truffle fix is delayed