Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
style: Rely on box-shadow to provide the secondary underline (#2283)
Closes #2282 Hello! # Description See #2282 for more details. Note that this change replaces the existing underline with a new one, and the new one is slightly differently aligned! I'd like for someone to approve this design change. This screenshot shows the before (above) and after (below): ![image](https://user-images.githubusercontent.com/37621491/216601388-42133013-fd44-485c-9ae8-bf52d5ad603a.png) Furthermore, I'm unsure about the removal of ```html &.excluded :deep() { .highlight__content { &:after { content: none; } } } ``` and I'd like to point out that there are [various other places](https://github.com/argilla-io/argilla/search?q=highlight__content) that modify `highlight__content` or `highlight__content::after`, which may need to be updated as well. If possible, someone with more experience of the codebase can have a look at this. **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) - [x] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [X] Merely a visual inspection. **Checklist** - [x] I have merged the original branch into my forked branch - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - Tom Aarsen
- Loading branch information