style: Rely on box-shadow to provide the secondary underline #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than ::after
tomaarsen
added
the
area: ui
leiyre
approved these changes
Feb 6, 2023
|
Sounds good! Do you suggest that I modify this PR to point to |
|
Yes, that's it. For fixes better |
|
I'll have to rebase to do that. I'll get on it when I have some more time tomorrow :) |
|
Other option is to merge to |
|
Sure! Even better. Thanks! |
tomaarsen
changed the title
frascuchon
added a commit
that referenced
this pull request
Feb 9, 2023
# Changelog All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. ## [1.3.0](v1.2.1...v1.3.0) (2023-02-09) ### Features * better log error handling ([#2245](#2245)) ([66e5cce](66e5cce)), closes [#2005](#2005) * Change view mode order in sidebar ([#2215](#2215)) ([dff1ea1](dff1ea1)), closes [#2214](#2214) * **Client:** Expose keywords dataset metrics ([#2290](#2290)) ([a945c5e](a945c5e)), closes [#2135](#2135) * **Client:** relax client constraints for rules management ([#2242](#2242)) ([6e749b7](6e749b7)), closes [#2048](#2048) * Create a multiple contextual help component ([#2255](#2255)) ([a35fae2](a35fae2)), closes [#1926](#1926) * Include record event_timestamp ([#2156](#2156)) ([3992b8f](3992b8f)), closes [#1911](#1911) * updated the `prepare_for_training` methods ([#2225](#2225)) ([e53c201](e53c201)), closes [#2154](#2154) [#2132](#2132) [#2122](#2122) [#2045](#2045) [#1697](#1697) ### Bug Fixes * **Client:** formatting caused offset in prediction ([#2241](#2241)) ([d65db5a](d65db5a)) * **Client:** Log remaining data when shutdown the dataset consumer ([#2269](#2269)) ([d78963e](d78963e)), closes [#2189](#2189) * validate predictions fails on text2text ([#2271](#2271)) ([f68856e](f68856e)), closes [#2252](#2252) ### Visual enhancements * Fine tune menu record card ([#2240](#2240)) ([62148e5](62148e5)), closes [#2224](#2224) * Rely on box-shadow to provide the secondary underline ([#2283](#2283)) ([d786171](d786171)), closes [#2282](#2282) [#2282](#2282) ### Documentation * Add deploy on Spaces buttons ([#2293](#2293)) ([60164a0](60164a0)) * fix typo in documentation ([#2296](#2296)) ([ab8e85e](ab8e85e)) * Improve deployment and quickstart docs and tutorials ([#2201](#2201)) ([075bf94](075bf94)), closes [#2162](#2162) * More spaces! ([#2309](#2309)) ([f02eb60](f02eb60)) * Remove cut-off sentence in docs codeblock ([#2287](#2287)) ([7e87f20](7e87f20)) * Rephrase `to know more` into `to learn more` in Quickstart login page ([#2305](#2305)) ([6082a26](6082a26)) * Replace leftover `rubrix.apikey` with `argilla.apikey` ([#2286](#2286)) ([4871127](4871127)), closes [#2254](#2254) [#2254](#2254) * Simplify token attributions code block ([#2322](#2322)) ([4cb6ae1](4cb6ae1)) * Tutorial buttons ([#2310](#2310)) ([d6e02de](d6e02de)) * Update colab guide ([#2320](#2320)) ([e48a7cc](e48a7cc)) * Update HF Spaces creation image ([#2314](#2314)) ([e4b2a04](e4b2a04)) ## As always, thanks to our amazing contributors! - add repr method for Rule, Dataset. (#2148) by @Ankush-Chander - opensearch docker compose file doesn't run (#2228) by @kayvane1 - Docs: fix typo in documentation (#2296) by @anakin87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2282
Hello!
Description
See #2282 for more details. Note that this change replaces the existing underline with a new one, and the new one is slightly differently aligned! I'd like for someone to approve this design change.
This screenshot shows the before (above) and after (below):
Furthermore, I'm unsure about the removal of
&.excluded :deep() { .highlight__content { &:after { content: none; } } }and I'd like to point out that there are various other places that modify
highlight__contentorhighlight__content::after, which may need to be updated as well. If possible, someone with more experience of the codebase can have a look at this.Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
I have merged the original branch into my forked branch
follows the style guidelines of this project
I did a self-review of my code
My changes generate no new warnings
Tom Aarsen