Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API key for default user to argilla.apikey #2250

Closed
frascuchon opened this issue Jan 26, 2023 · 0 comments · Fixed by #2254
Closed

Update API key for default user to argilla.apikey #2250

frascuchon opened this issue Jan 26, 2023 · 0 comments · Fixed by #2254
Assignees
@dvsrepo @frascuchon @davidberenstein1957 @rhoitjadhav
Labels
area: server Indicates that an issue or pull request is related to the server type: documentation Improvements or additions to documentation
Milestone
v1.3.0

Comments

@frascuchon
Copy link
Member

frascuchon commented Jan 26, 2023 •
edited

  • The default API KEY will be defined as argilla.apikey
  • The old API KEY will be accepted when default API KEY is not changed
  • Docs must be updated to point this new API KEY value. And also, warning about new clients connecting to old servers. For example:

To connect to an old Argilla server using client >=1.3.0, you should specify the default user API key rubrix.apikey. Otherwise, connections will fail with an Unauthorized server error.
@frascuchon frascuchon self-assigned this Jan 26, 2023
@frascuchon frascuchon added this to the v1.3.0 milestone Jan 26, 2023
@frascuchon frascuchon mentioned this issue Jan 27, 2023
Closed
@frascuchon frascuchon changed the title Allow also argilla.apikey for the default user Allow also argilla.apikey for the default user Jan 27, 2023
@frascuchon frascuchon changed the title Allow also argilla.apikey for the default user Update API key for default user to argilla.apikey Jan 27, 2023
@frascuchon frascuchon added area: server Indicates that an issue or pull request is related to the server client type: documentation Improvements or additions to documentation labels Jan 27, 2023
@frascuchon frascuchon mentioned this issue Jan 27, 2023
Merged
10 tasks
frascuchon added a commit that referenced this issue Feb 2, 2023
@frascuchon @rhoitjadhav
refactor: Change the default api key to argilla.apikey (#2254)
79e27fe 
# Description

This PR adds code to change the default API key to `argilla.apikey`,
with backward compatibility with old apikey.

Closes #2250 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Refactor (change restructuring the codebase without changing
functionality)
- [x] Documentation update

**Checklist**

- [x] I have merged the original branch into my forked branch
- [x] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] I added comments to my code
- [x] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works

---------

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
Co-authored-by: rhoitjadhav <jadhavrohit497@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvsrepo dvsrepo

@frascuchon frascuchon

@davidberenstein1957 davidberenstein1957

@rhoitjadhav rhoitjadhav

Labels
area: server Indicates that an issue or pull request is related to the server type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

refactor: Change the default api key to argilla.apikey argilla-io/argilla
4 participants
@dvsrepo @frascuchon @davidberenstein1957 @rhoitjadhav