Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change the default api key to argilla.apikey #2254

Merged
merged 3 commits into from Feb 2, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jan 27, 2023

Description

This PR adds code to change the default API key to argilla.apikey, with backward compatibility with old apikey.

Closes #2250

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Refactor (change restructuring the codebase without changing functionality)
  • Documentation update

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I added comments to my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@frascuchon frascuchon requested review from dvsrepo and removed request for dvsrepo January 27, 2023 09:53
@frascuchon frascuchon assigned dvsrepo and rhoitjadhav and unassigned dvsrepo Jan 27, 2023
@frascuchon
Copy link
Member Author

@rhoitjadhav
Could you update the docs with this new default value? Also, add a disclaimer/info/warn for old server connections as suggested in the issue.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 93.03% // Head: 92.99% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7e1eaa6) compared to base (20bb333).
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head 7e1eaa6 differs from pull request most recent head b82b0c5. Consider uploading reports for the commit b82b0c5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2254      +/-   ##
===========================================
- Coverage    93.03%   92.99%   -0.05%     
===========================================
  Files          159      159              
  Lines         7701     7705       +4     
===========================================
  Hits          7165     7165              
- Misses         536      540       +4     
Flag Coverage Δ
pytest 92.99% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/server/security/auth_provider/local/users/dao.py 90.62% <66.66%> (-2.48%) ⬇️
src/argilla/_constants.py 100.00% <100.00%> (ø)
...gilla/labeling/text_classification/label_errors.py 86.58% <0.00%> (-3.66%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhoitjadhav
Copy link
Contributor

rhoitjadhav commented Jan 27, 2023

@frascuchon I have to make the changes In the same PR branch right?

@frascuchon
Copy link
Member Author

@frascuchon I have to make the changes In the same PR branch right?

Yes, you can add your changes here.

@rhoitjadhav
Copy link
Contributor

rhoitjadhav commented Jan 30, 2023

Updated the docs with new default api key

@frascuchon frascuchon marked this pull request as ready for review January 30, 2023 15:25
@frascuchon frascuchon merged commit 79e27fe into develop Feb 2, 2023
@frascuchon frascuchon deleted the refactor/change-default-apikey branch February 2, 2023 22:07
tomaarsen added a commit to tomaarsen/argilla that referenced this pull request Feb 3, 2023
frascuchon pushed a commit that referenced this pull request Feb 3, 2023
Related to #2254

# Description

Replace leftover `rubrix.apikey` with `argilla.apikey`, a la #2254.
Ignore the weird commit message artifacting, I always forget that I
can't use ` in my commit messages on Windows.

**Type of change**

- [x] Documentation update

**How Has This Been Tested**
N/A

**Checklist**
- [x] I have merged the original branch into my forked branch
frascuchon added a commit that referenced this pull request Feb 9, 2023
# Changelog

All notable changes to this project will be documented in this file. See
[standard-version](https://github.com/conventional-changelog/standard-version)
for commit guidelines.

## [1.3.0](v1.2.1...v1.3.0)
(2023-02-09)


### Features

* better log error handling
([#2245](#2245))
([66e5cce](66e5cce)),
closes [#2005](#2005)
* Change view mode order in sidebar
([#2215](#2215))
([dff1ea1](dff1ea1)),
closes [#2214](#2214)
* **Client:** Expose keywords dataset metrics
([#2290](#2290))
([a945c5e](a945c5e)),
closes [#2135](#2135)
* **Client:** relax client constraints for rules management
([#2242](#2242))
([6e749b7](6e749b7)),
closes [#2048](#2048)
* Create a multiple contextual help component
([#2255](#2255))
([a35fae2](a35fae2)),
closes [#1926](#1926)
* Include record event_timestamp
([#2156](#2156))
([3992b8f](3992b8f)),
closes [#1911](#1911)
* updated the `prepare_for_training` methods
([#2225](#2225))
([e53c201](e53c201)),
closes [#2154](#2154)
[#2132](#2132)
[#2122](#2122)
[#2045](#2045)
[#1697](#1697)


### Bug Fixes

* **Client:** formatting caused offset in prediction
([#2241](#2241))
([d65db5a](d65db5a))
* **Client:** Log remaining data when shutdown the dataset consumer
([#2269](#2269))
([d78963e](d78963e)),
closes [#2189](#2189)
* validate predictions fails on text2text
([#2271](#2271))
([f68856e](f68856e)),
closes [#2252](#2252)


### Visual enhancements

* Fine tune menu record card
([#2240](#2240))
([62148e5](62148e5)),
closes [#2224](#2224)
* Rely on box-shadow to provide the secondary underline
([#2283](#2283))
([d786171](d786171)),
closes [#2282](#2282)
[#2282](#2282)


### Documentation

* Add deploy on Spaces buttons
([#2293](#2293))
([60164a0](60164a0))
* fix typo in documentation
([#2296](#2296))
([ab8e85e](ab8e85e))
* Improve deployment and quickstart docs and tutorials
([#2201](#2201))
([075bf94](075bf94)),
closes [#2162](#2162)
* More spaces! ([#2309](#2309))
([f02eb60](f02eb60))
* Remove cut-off sentence in docs codeblock
([#2287](#2287))
([7e87f20](7e87f20))
* Rephrase `to know more` into `to learn more` in Quickstart login page
([#2305](#2305))
([6082a26](6082a26))
* Replace leftover `rubrix.apikey` with `argilla.apikey`
([#2286](#2286))
([4871127](4871127)),
closes [#2254](#2254)
[#2254](#2254)
* Simplify token attributions code block
([#2322](#2322))
([4cb6ae1](4cb6ae1))
* Tutorial buttons
([#2310](#2310))
([d6e02de](d6e02de))
* Update colab guide
([#2320](#2320))
([e48a7cc](e48a7cc))
* Update HF Spaces creation image
([#2314](#2314))
([e4b2a04](e4b2a04))


## As always, thanks to our amazing contributors!


- add repr method for Rule, Dataset. (#2148) by @Ankush-Chander
- opensearch docker compose file doesn't run (#2228) by @kayvane1
- Docs: fix typo in documentation (#2296) by @anakin87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API key for default user to argilla.apikey
3 participants