Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include CI/CD for docs #4895

Closed
Tracked by #4888
davidberenstein1957 opened this issue May 28, 2024 · 1 comment · Fixed by #4891
Closed
Tracked by #4888

include CI/CD for docs #4895

davidberenstein1957 opened this issue May 28, 2024 · 1 comment · Fixed by #4891
Assignees

Comments

@davidberenstein1957
Copy link
Member

No description provided.

@frascuchon
Copy link
Member

@davidberenstein1957 Almost everything is working in #4891. The only missing part is the gh-pages branch configuration, required by the docs CI

You can start working from #4891

@frascuchon frascuchon linked a pull request Jun 3, 2024 that will close this issue
13 tasks
frascuchon added a commit that referenced this issue Jun 4, 2024
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

This PR setup the argilla-sdk project. This PR only copy the code base
from the [argilla-python
repository](https://github.com/argilla-io/argilla-python). ~~No changes
in package definition or docs have been applied yet.~~ UPDATED: The only
change is [this
line](https://github.com/argilla-io/argilla/blob/feat/add-new-sdk-project/argilla-sdk/src/argilla_sdk/_helpers/_uuid.py#L61)
which raise an ruff error when applying commit hooks.

## Update

The code on this PR won't work with the server version on `feat/v2.0.0`
until we resolve SDK tasks for the issue
#4773. For the sake of the
review complexity, I would prefer to tackle this migration as a separate
PR.

After those changes, the new SDK will still be fully compatible with
argilla server 1.29.0.

Closes #4888
Closes #4895

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] New feature (non-breaking change which adds functionality)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [ ] Test A
- [ ] Test B

**Checklist**

- [ ] I added relevant documentation
- [ ] I followed the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants