Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT BRANCH] Add argilla-sdk project #4891

Merged
merged 19 commits into from
Jun 4, 2024
Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented May 28, 2024

Description

This PR setup the argilla-sdk project. This PR only copy the code base from the argilla-python repository. No changes in package definition or docs have been applied yet. UPDATED: The only change is this line which raise an ruff error when applying commit hooks.

Update

The code on this PR won't work with the server version on feat/v2.0.0 until we resolve SDK tasks for the issue #4773. For the sake of the review complexity, I would prefer to tackle this migration as a separate PR.

After those changes, the new SDK will still be fully compatible with argilla server 1.29.0.

Closes #4888
Closes #4895

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the title Feat/add new sdk project [Feat] Add new sdk project May 28, 2024
@frascuchon frascuchon changed the title [Feat] Add new sdk project [FEAT BRANCH] Add new sdk project May 28, 2024
@frascuchon frascuchon changed the title [FEAT BRANCH] Add new sdk project [FEAT BRANCH] Add argilla-sdk project May 28, 2024
@frascuchon frascuchon changed the base branch from feat/v2.0.0 to develop June 3, 2024 09:08
@frascuchon frascuchon changed the base branch from develop to feat/v2.0.0 June 3, 2024 13:08
Copy link

github-actions bot commented Jun 3, 2024

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4891-ki24f765kq-no.a.run.app

# Repository
repo_name: argilla-io/argilla-python
repo_url: https://github.com/argilla-io/argilla-python
edit_uri: edit/main/docs/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this line in the latest sync. Should this affect the current project setup? In that case, should we comment until we have merged the project into the default/develop/main one? cc @davidberenstein1957 @burtenshaw

@frascuchon
Copy link
Member Author

This PR just applies some minimal changes for the argilla SDK docs
generation:

- Freeze the default branch to `feat/v2.0.0`
- Launch a docs generation for docs branches starting with `docs/**`
- Remove PR-related events from triggers.
@frascuchon frascuchon linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Contributor

@sdiazlor sdiazlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the docs, looks like they are all.

@frascuchon frascuchon merged commit 9e97517 into feat/v2.0.0 Jun 4, 2024
7 of 8 checks passed
@frascuchon frascuchon deleted the feat/add-new-sdk-project branch June 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include CI/CD for docs
3 participants