Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): indexing keyword fields with textual info #1197

Merged
merged 2 commits into from Feb 23, 2022
Merged

feat(search): indexing keyword fields with textual info #1197

merged 2 commits into from Feb 23, 2022

Conversation

frascuchon
Copy link
Member

This PR configures some keyword files (like metadata.* or some token classification mentions metrics) to allow in search phase query as a full text search.

For example:

metadata.long_text.text: find me*

@frascuchon frascuchon added this to In progress in Release via automation Feb 22, 2022
@frascuchon frascuchon added type: enhancement Indicates new feature requests area: server Indicates that an issue or pull request is related to the server labels Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited

Codecov Report

Merging #1197 (bfcafee) into master (1803531) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
+ Coverage   94.99%   95.01%   +0.02%     
==========================================
  Files         124      124              
  Lines        4955     4959       +4     
==========================================
+ Hits         4707     4712       +5     
+ Misses        248      247       -1
Flag Coverage Δ
pytest 95.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../server/tasks/text_classification/dao/es_config.py 100.00% <ø> (ø)
src/rubrix/server/commons/es_helpers.py 86.42% <100.00%> (+0.51%) ⬆️
src/rubrix/server/tasks/commons/dao/es_config.py 98.27% <100.00%> (+0.09%) ⬆️
...server/tasks/token_classification/dao/es_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6489c7...bfcafee. Read the comment docs.

dcfidalgo
dcfidalgo approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@frascuchon frascuchon merged commit ab80cbc into master Feb 23, 2022
@frascuchon frascuchon deleted the feature/extend-keyword-field-indexing branch February 23, 2022 13:27
@frascuchon frascuchon moved this from In progress to Review in Release Feb 23, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Mar 2, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this pull request Mar 25, 2022
@frascuchon
feat(#950): indexing keyword fields with textual info (#1197)
0c3c98d 
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
feat(#950): indexing keyword fields with textual info (#1197)
70f25a5 
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
feat(#950): indexing keyword fields with textual info (#1197)
02f537a 
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
@frascuchon frascuchon moved this from Approved Release QA to Ready to Release QA in Release Mar 28, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 30, 2022
@frascuchon
feat(#950): indexing keyword fields with textual info (#1197)
1313bab 
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcfidalgo dcfidalgo dcfidalgo approved these changes

@dvsrepo dvsrepo Awaiting requested review from dvsrepo

Assignees
No one assigned
Labels
area: server Indicates that an issue or pull request is related to the server type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frascuchon @dcfidalgo