Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: include es 8.0 in build process #1286

Merged
merged 4 commits into from Mar 22, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 22, 2022

This PR includes required changes to make rubrix compatible with the new elasticsearch 8.x version.

The main changes are:

  • Use id field as default sort key, instead of the _id field, which is disabled as default for this es version
  • Avoid to define nested fields in mappings. This configuration was deprecated in previos versions and is not allowed in last version. This changes affect to metadata.* fields and how the text searches can be used over them. String metadata fields are defined as keywords, and extends the 2 subfields text and exact for textual queries. You should use them in query string as follows:
metadata.my_field.text:total effort
# or
metadata.my_field.exact:Total Effor~

@frascuchon frascuchon marked this pull request as ready for review March 22, 2022 16:57
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1286 (5fa7673) into master (cd2b5c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1286   +/-   ##
=======================================
  Coverage   93.98%   93.99%           
=======================================
  Files         129      129           
  Lines        5800     5808    +8     
=======================================
+ Hits         5451     5459    +8     
  Misses        349      349           
Flag Coverage Δ
pytest 93.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/tasks/commons/dao/dao.py 97.93% <ø> (ø)
src/rubrix/server/tasks/commons/dao/es_config.py 98.33% <100.00%> (+0.05%) ⬆️
src/rubrix/server/security/model.py 100.00% <0.00%> (ø)
...rubrix/server/tasks/text_classification/metrics.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2b5c9...5fa7673. Read the comment docs.

Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frascuchon frascuchon merged commit 2eb5276 into master Mar 22, 2022
@frascuchon frascuchon deleted the refactor/include-elasticsearch-8 branch March 22, 2022 20:41
frascuchon added a commit that referenced this pull request Mar 24, 2022
* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile
@frascuchon frascuchon added this to In progress in Release via automation Mar 25, 2022
@frascuchon frascuchon moved this from In progress to Ready to DEV QA in Release Mar 25, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this pull request Mar 25, 2022
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 28, 2022
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
frascuchon added a commit that referenced this pull request Mar 28, 2022
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
frascuchon added a commit that referenced this pull request Mar 30, 2022
* feat(search): indexing keyword fields with textual info

* fix: properties -> fields

(cherry picked from commit ab80cbc)

ci: include es 8.0 in build process (#1286)

* ci: include es 8.0 in build process

* chore: wip

* fix(es-mapping): avoid nested multi-fields in mapping

* fix(search): use id for default sorting

(cherry picked from commit 2eb5276)

fix(#1286): backward comp. sorting by id (#1304)

* fix(search): backward comp. sorting by id

* fix: error normalizing sort

* chore: dockerfile

(cherry picked from commit a3b0552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants