Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): prevent exceed search.max buckets for metadata fields #1401

Conversation

frascuchon
Copy link
Member

After the changes included in #1396, we could find errors related to search.max_buckets configuration. This PR includes some checks and reactors to avoid that, especially for metadata fields.

@frascuchon frascuchon self-assigned this Apr 11, 2022
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Apr 11, 2022
@frascuchon frascuchon requested a review from dvsrepo April 11, 2022 10:09
@frascuchon frascuchon added this to In progress in Release via automation Apr 11, 2022
Release automation moved this from In progress to Review OK Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1401 (27b0402) into master (523ba44) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
+ Coverage   94.41%   94.43%   +0.01%     
==========================================
  Files         130      130              
  Lines        5877     5889      +12     
==========================================
+ Hits         5549     5561      +12     
  Misses        328      328              
Flag Coverage Δ
pytest 94.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/es_helpers.py 85.00% <100.00%> (+0.06%) ⬆️
.../rubrix/server/tasks/commons/metrics/model/base.py 94.50% <100.00%> (+0.06%) ⬆️
src/rubrix/server/tasks/commons/metrics/service.py 98.38% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ebff2...27b0402. Read the comment docs.

@frascuchon frascuchon merged commit 125c6b8 into master Apr 11, 2022
@frascuchon frascuchon deleted the bugfixes/prevent-exceed-search.max_buckets-for-metadata-fields branch April 11, 2022 10:54
frascuchon added a commit that referenced this pull request Apr 11, 2022
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
frascuchon added a commit that referenced this pull request Apr 11, 2022
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
2 participants