Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve performance of filter selectors #1399

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: improve performance of filter selectors #1399

merged 1 commit into from
Apr 11, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Apr 11, 2022 •
edited by frascuchon

See #1387
This PR improves the performance of filter selectors by adding lazy loading and rendering only when they are visible.

fix(#1387): improve performance of filter selectors
af6a0de 
fix #1387
This PR improves the performance of filter selectors by adding lazy loading and rendering only when they are visible.
@leiyre leiyre requested a review from frascuchon April 11, 2022 08:23
@frascuchon frascuchon linked an issue Apr 11, 2022 that may be closed by this pull request
TokenClassificationRecord metadata menu seems to limit number of entries to 100 even if there are more in the dataset. #1387
Closed
@frascuchon frascuchon changed the title fix(#1387): improve performance of filter selectors fix: improve performance of filter selectors Apr 11, 2022
@frascuchon frascuchon merged commit b6a8eae into master Apr 11, 2022
@frascuchon frascuchon deleted the fix/long_values_list_filters branch April 11, 2022 10:41
frascuchon pushed a commit that referenced this pull request Apr 11, 2022
fix(#1387): improve metadata distinct values computation
5dc767a 
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
frascuchon pushed a commit that referenced this pull request Apr 11, 2022
fix(#1387): improve metadata distinct values computation
be9f68f 
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leiyre @frascuchon