feat: Accept non searchable fields in metadata #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith "_" Metadata fields starting with "_" are not available for search filter or aggregate
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2570 +/- ##
========================================
Coverage 93.53% 93.53%
========================================
Files 157 158 +1
Lines 7839 7861 +22
========================================
+ Hits 7332 7353 +21
- Misses 507 508 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jfcalvo
requested changes
Mar 17, 2023
Co-authored-by: José Francisco Calvo <jose@argilla.io>
jfcalvo
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Everything looks fine.
Only one last thing. I have not found any of the tests testing if the non-searchable fields are actually non-searchable. I mean adding a _this: myspecialanduniqueword field and try to search for it with myspecialanduniqueword and no documents are returned. If you think this could be useful please add it.
|
Feel free to merge. |
Merged
frascuchon
added a commit
that referenced
this pull request
Mar 22, 2023
## [1.5.0](v1.4.0...v1.5.0) - 2023-03-21 ### Added - Add the fields to retrieve when loading the data from argilla. `rg.load` takes too long because of the vector field, even when users don't need it. Closes [#2398](#2398) - Add new page and components for dataset settings. Closes [#2442](#2003) - Add ability to show image in records (for TokenClassification and TextClassification) if an URL is passed in metadata with the key \_image_url - Non-searchable fields support in metadata. [#2570](#2570) ### Changed - Labels are now centralized in a specific vuex ORM called GlobalLabel Model, see #2210. This model is the same for TokenClassification and TextClassification (so both task have labels with color_id and shortcuts parameters in the vuex ORM) - The shortcuts improvement for labels [#2339](#2339) have been moved to the vuex ORM in dataset settings feature [#2444](eb37c3b) - Update "Define a labeling schema" section in docs. - The record inputs are sorted alphabetically in UI by default. [#2581](#2581) ### Fixes - Allow URL to be clickable in Jupyter notebook again. Closes [#2527](#2527) ### Removed - Removing some data scan deprecated endpoints used by old clients. This change will break compatibility with client `<v1.3.0` - Stop using old scan deprecated endpoints in python client. This logic will break client compatibility with server version `<1.3.0` - Remove the previous way to add labels through the dataset page. Now labels can be added only through dataset settings page. ### As always, thanks to our amazing contributors! - Documentation update: tutorial for text classification models comparison (#2426) by @embonhomme - Docs: fix little typo (#2522) by @anakin87 - Docs: Tutorial on image classification (#2420) by @burtenshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes for those cases when users want to add some fields in metadata but do not enable searches on them with a leading underscore
_.Refs: #2571
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
Checklist