Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add update_vectors_settings function #4122

Merged
merged 17 commits into from
Nov 3, 2023
Merged

feat: add update_vectors_settings function #4122

merged 17 commits into from
Nov 3, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

This PR adds the update_vectors_settings method to the RemoteFeedbackDataset class that allows to update a list of vectors settings from the dataset calling the Argilla API.

Closes #4105

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

I've added tests that covers the additions.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests client labels Nov 2, 2023
@gabrielmbmb gabrielmbmb added this to the v1.19.0 milestone Nov 2, 2023
@gabrielmbmb gabrielmbmb self-assigned this Nov 2, 2023
@gabrielmbmb gabrielmbmb changed the base branch from develop to feature/feedback-dataset-semantic-similarity November 2, 2023 17:38
@gabrielmbmb gabrielmbmb marked this pull request as draft November 2, 2023 17:50
@gabrielmbmb gabrielmbmb force-pushed the feature/add-update-vector-settings-method branch from 89a17b5 to f5af8c7 Compare November 2, 2023 17:50
@gabrielmbmb gabrielmbmb marked this pull request as ready for review November 3, 2023 08:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4122-ki24f765kq-no.a.run.app

@gabrielmbmb gabrielmbmb force-pushed the feature/add-update-vector-settings-method branch from e4a4b66 to c886798 Compare November 3, 2023 12:08
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/argilla/client/feedback/dataset/base.py 86.54% <100.00%> (ø)
...rc/argilla/client/feedback/dataset/local/mixins.py 84.01% <100.00%> (-4.15%) ⬇️
...argilla/client/feedback/schemas/vector_settings.py 100.00% <100.00%> (ø)
src/argilla/client/sdk/v1/datasets/api.py 91.44% <100.00%> (ø)
src/argilla/client/sdk/v1/datasets/models.py 100.00% <100.00%> (ø)
...c/argilla/client/sdk/v1/vectors_settings/models.py 100.00% <100.00%> (ø)
...c/argilla/client/feedback/dataset/local/dataset.py 86.87% <83.33%> (-0.09%) ⬇️
.../client/feedback/schemas/remote/vector_settings.py 92.30% <66.66%> (-7.70%) ⬇️
src/argilla/client/sdk/v1/vectors_settings/api.py 92.30% <92.30%> (ø)
.../argilla/client/feedback/dataset/remote/dataset.py 92.44% <84.61%> (-0.12%) ⬇️

📢 Thoughts on this report? Let us know!.

@gabrielmbmb gabrielmbmb force-pushed the feature/add-update-vector-settings-method branch from 6998a81 to 9d58254 Compare November 3, 2023 13:20
alvarobartt
alvarobartt approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/argilla/client/feedback/dataset/remote/dataset.py Outdated Show resolved Hide resolved
src/argilla/client/feedback/schemas/vector_settings.py Outdated Show resolved Hide resolved
src/argilla/client/feedback/schemas/vector_settings.py Show resolved Hide resolved
@gabrielmbmb gabrielmbmb force-pushed the feature/add-update-vector-settings-method branch from 2200d77 to 019699c Compare November 3, 2023 15:09
@gabrielmbmb gabrielmbmb merged commit 03208ad into feature/feedback-dataset-semantic-similarity Nov 3, 2023
14 checks passed
@gabrielmbmb gabrielmbmb deleted the feature/add-update-vector-settings-method branch November 3, 2023 15:32
leiyre pushed a commit that referenced this pull request Nov 6, 2023
Merge branch 'feature/feedback-dataset-semantic-similarity' into feat…
6832b2d 
…/new-filter-area-ui

* feature/feedback-dataset-semantic-similarity:
  feat: add sdk update records with vectors (#4128)
  ⚡️ Remove unused args
  ✨ Remove unused requests
  feat: add `delete_vectors_settings` method (#4130)
  feat: add SDK support for search records with similarity (#4023)
  ✨ No capitalized name for Fields, Questions, Metadata and Vectors tab.
  feat: add `update_vectors_settings` function (#4122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon left review comments

@alvarobartt alvarobartt alvarobartt approved these changes

@jfcalvo jfcalvo Awaiting requested review from jfcalvo

Assignees

@gabrielmbmb gabrielmbmb

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Define dataset.update_vector_settings method in the Python SDK
3 participants
@gabrielmbmb @frascuchon @alvarobartt