Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log if a dataset is deleted #4752

Merged
merged 1 commit into from
May 13, 2024

Conversation

paulbauriegel
Copy link
Contributor

Generic Pull Request Template

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #4751

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code type: enhancement Indicates new feature requests labels Apr 25, 2024
@paulbauriegel
Copy link
Contributor Author

The CICD Pipeline run into some error, but that should not be connected to this change:
ValueError: No token found. Please set HF_HUB_ACCESS_TOKEN environment variable.

@frascuchon frascuchon self-requested a review May 13, 2024 08:37
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @paulbauriegel!

@frascuchon frascuchon merged commit 7720dc4 into argilla-io:develop May 13, 2024
13 of 14 checks passed
sdiazlor added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code size:XS This PR changes 0-9 lines, ignoring generated files. type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable logging for deletion of datasets
2 participants