Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WeakLabels] Align WeakLabels.summary() with web app #925

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

dcfidalgo
Copy link
Contributor

Closes #894

@dcfidalgo dcfidalgo added this to In progress in v0.8.0 via automation Jan 11, 2022
@dcfidalgo dcfidalgo self-assigned this Jan 11, 2022
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Just fix failing tests before merge to master

@frascuchon frascuchon moved this from In progress to Reviewer approved in v0.8.0 Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #925 (9f4edeb) into master (3255b96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         109      109           
  Lines        4206     4209    +3     
=======================================
+ Hits         4017     4020    +3     
  Misses        189      189           
Flag Coverage Δ
pytest 95.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rubrix/labeling/text_classification/weak_labels.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3255b96...9f4edeb. Read the comment docs.

@dcfidalgo dcfidalgo merged commit f6dbec4 into master Jan 11, 2022
v0.8.0 automation moved this from Reviewer approved to Done Jan 11, 2022
@dcfidalgo dcfidalgo deleted the feat/align_weaklabels_summary branch January 11, 2022 12:26
frascuchon pushed a commit that referenced this pull request Jan 11, 2022
* polarity to label + annotated_coverage

* update tests

* fix annotated coverage computation

* fix test
@dcfidalgo dcfidalgo moved this from Done to Release Ready in v0.8.0 Jan 12, 2022
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix:
  fix links to new web app reference (#936)
  [WeakSupervision] Change load_rules import path in guide and tutorial (#939)
  chore(docs): improves readme for mobile (#938)
  Bugfixes/avoid infinite loop when dataset loading (#934)
  show nan instead of 0 for precision in summary (#930)
  fix(api): include_metrics param only for search endponts (#929)
  [Documentation] Update title page video for docs (#928)
  update skweak tutorial (#922)
  [Documentation] Updating the web app docu (#827)
  revert test.pypi publish
  publish python package to test.pypi for master and releases branches (#927)
  [WeakLabels] Align WeakLabels.summary() with web app (#925)
  UI: show rules without precision properly (#919)
  chore(build): build docker images for release branches (#921)
  Docs: Updates readme front video (#923)
  Docs: Updates weak supervision resources (#920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.8.0
Release Ready
Development

Successfully merging this pull request may close these issues.

[WeakLabels] Align WeakLabels.summary with the web app's "manage rule" page
2 participants