Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure ValueSet doesn't match description #59

Open
jmandel opened this issue Oct 5, 2018 · 10 comments
Open

Procedure ValueSet doesn't match description #59

jmandel opened this issue Oct 5, 2018 · 10 comments

Comments

@jmandel
Copy link

jmandel commented Oct 5, 2018

The spec is inconsistent about whether ICD10 is allowed for Procedure codes.

http://www.fhir.org/guides/argonaut/r2/ValueSet-procedure-type.json.html shows

 "compose" : {
    "include" : [
      {
        "system" : "http://www.ama-assn.org/go/cpt"
      },
      {
        "system" : "http://snomed.info/sct",
        "filter" : [
          {
            "property" : "concept",
            "op" : "is-a",
            "value" : "71388002"
          }
        ]
      }
    ]
  }

but the rendering at http://www.fhir.org/guides/argonaut/r2/StructureDefinition-argo-procedure.html shows:
image

@brettmarquard
Copy link
Collaborator

I recognize this isn't pretty - how can we improve the intent:

  • SHALL SNOMED or CPT.
  • MAY have ICD-10 in translation.

any ideas @Healthedata1 ?

Here is what we have on the profile page:

One Identification of the procedure in Procedure.code which has:

  • extensible + max valueset binding to the US Core Procedure Codes valueset (SNOMED CT or CPT-4/HCPC for procedures).
  • MAY have a translation to ICD-10-PCS or Code on Dental Procedures and Nomenclature (CDT Codes).

@jmandel
Copy link
Author

jmandel commented Oct 5, 2018

First off I may just need education: I see http://build.fhir.org/extension-elementdefinition-maxvalueset.html but I'm not sure I understand how "extensible+max" is different from "required"? Does it mean that implementers are supposed to use free-text instead of picking a code from outside of this list?

Other questions:

  • Can't a CodeableConcept always have multiple Codings? What does "translation" here mean with respect to ICD-10/CdT?

  • Is the intention to prevent other translations from being included? Or, what is the goal of the "MAY"?

@Healthedata1
Copy link
Collaborator

Healthedata1 commented Oct 5, 2018 via email

@Healthedata1
Copy link
Collaborator

Healthedata1 commented Oct 5, 2018 via email

@jmandel
Copy link
Author

jmandel commented Oct 5, 2018

Thanks for the explanation! I'm at a loss to understand the inteded purpose and intended behavior of this "max binding". Does it prevent you from using any Coding from, say, a nonstandard vocabulary and force you to instep use a free text representation? If so, what is the rationale for this?

And more generally, I'm just sure I understand how a "max" binding applies to a list of Codings -- obviously it isn't constraint all of the Codings, or else the "may use ICD 10" wouldn't apply. So what exactly is the intended logic?

Reading the one sentence extensions definition wasn't helped.

I wonder @grahamegrieve if you're able to shed light. Do you support max?

@Healthedata1
Copy link
Collaborator

Healthedata1 commented Oct 5, 2018 via email

@jmandel
Copy link
Author

jmandel commented Oct 5, 2018

Thanks for the details -- though I'm still struggling to understand.

@daliboz do you have a clear explanation of what this extensible/max thing is all about, and what it achieves over regular extensible bindings?

@daliboz
Copy link

daliboz commented Jan 12, 2019

As to the technical implementation of it, no. I believe Eric worked with Grahame to determine how to implement the limitation technically.

The functional want was to allow freetext (text only), but not get into the realm of allowing any random codings (without one of the "required" ones being present as well). This approach was used throughout the Argonaut specification. We would have used required, except that it does not allow for there to be text with no code.

@brettmarquard
Copy link
Collaborator

The name of the 'extensible+max' continues to cause confusion....

@grahamegrieve @Healthedata1 , any chance we can come up with a new name? "Required + Text allowed" Or something that gives a clue to the implementer.

@Healthedata1
Copy link
Collaborator

Healthedata1 commented Jan 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants