Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent flag to specify registries config #290

Closed
janpieper opened this issue Nov 3, 2021 · 3 comments
Closed

Inconsistent flag to specify registries config #290

janpieper opened this issue Nov 3, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v0.12.0

Comments

@janpieper
Copy link
Contributor

Describe the bug

The flag to specify the registries config file is inconsistent.

To Reproduce

$ argocd-image-updater run --help | grep registries-conf
      --registries-conf-path string      path to registries configuration file (default "/app/config/registries.conf")

vs.

$ argocd-image-updater test --help | grep registries-conf
      --registries-conf string      path to registries configuration

Expected behavior

Have --registries-conf OR --registries-conf-path for both commands.

Additional context

None

Version

0.11.0

Logs

None
@janpieper janpieper added the bug Something isn't working label Nov 3, 2021
@jannfis
Copy link
Contributor

jannfis commented Nov 5, 2021

Good catch. I think for better backwards compatibility, we should reuse what's defined for the run command, so --registries-conf-path.

@jannfis jannfis added the good first issue Good for newcomers label Nov 5, 2021
janpieper added a commit to janpieper/argocd-image-updater that referenced this issue Nov 8, 2021
@janpieper
fix: Rename flag to specify registries config path (argoproj-labs#290)
fab995f 
Signed-off-by: Jan Pieper <kontakt@jan-pieper.info>
@janpieper janpieper mentioned this issue Nov 8, 2021
Merged
jannfis pushed a commit that referenced this issue Nov 10, 2021
@janpieper
fix: Rename flag to specify registries config path (#290) (#295)
934f7c5 
Signed-off-by: Jan Pieper <kontakt@jan-pieper.info>
tuananh pushed a commit to tuananh/argocd-image-updater that referenced this issue Nov 11, 2021
@janpieper @tuananh
fix: Rename flag to specify registries config path (argoproj-labs#290) (
b38114a 
argoproj-labs#295)

Signed-off-by: Jan Pieper <kontakt@jan-pieper.info>
@janpieper-gcx
Copy link
Contributor

Fixed by #295

@janpieper-gcx
Copy link
Contributor

@jannfis Hmmm, I cannot close this issue 🤔

@jannfis jannfis closed this as completed Dec 19, 2021
@jannfis jannfis added this to the v0.12.0 milestone Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
3 participants
@janpieper @jannfis @janpieper-gcx