fix: Have consistent flag to specify registries conf path #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Pieper <kontakt@jan-pieper.info>
|
Is it okay to fully remove We could add some kind of deprecation warning if someone is still using @jannfis what do you think? |
|
Hey @janpieper, thanks for this PR. I think the |
jannfis
approved these changes
Nov 10, 2021
jannfis
changed the title
tuananh
pushed a commit
to tuananh/argocd-image-updater
that referenced
this pull request
Nov 11, 2021
argoproj-labs#295) Signed-off-by: Jan Pieper <kontakt@jan-pieper.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
--registries-confof thetest-command to--registries-conf-pathlike we already use for therun-command.The issue has been described in #290.