Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support OCI repositories by using distribution/v3 #249

Merged
merged 11 commits into from
Sep 17, 2021

Conversation

ludovicMercier
Copy link
Contributor

@ludovicMercier ludovicMercier commented Sep 2, 2021

Implement distribution/v3 which is the last version of docker/distribution and support oci manisfest to solve #236

Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@ludovicMercier ludovicMercier changed the title Distribution/v3 Upgrade to Distribution/v3 to solve #236 Sep 2, 2021
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
Signed-off-by: ludovicMercier <ludovic.mercier.lm@gmail.com>
@jannfis
Copy link
Contributor

jannfis commented Sep 9, 2021

Thanks for this PR, @ludovicMercier!

Please allow me some time for proper review - it's a quite complex change.

@ludovicMercier
Copy link
Contributor Author

Hi @jannfis,
I agree with you, take the time you need on the review.

@jannfis
Copy link
Contributor

jannfis commented Sep 16, 2021

@ludovicMercier I gave this PR some quick tests, and it worked great so far! I could even observe some performance improvements in contrast to using the (pretty old) docker-registry-client library.

I adapted my local checkout of your PR's branch to include latest changes in master branch, do you mind if I push them back to your PR's branch (or send a PR to your fork)?

I think it's good to merge, I just have a couple of tests in queue to perform either tomorrow or on the weekend.

Thank you! I really appreciate this contribution.

@ludovicMercier
Copy link
Contributor Author

ludovicMercier commented Sep 17, 2021

Hi @jannfis,
You can merge directly in this PR it's ok to me.
If i see someting else where i can help i'll rebase my fork to stay updated with the project.

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis changed the title Upgrade to Distribution/v3 to solve #236 feat: Support OCI repositories by using distribution/v3 Sep 17, 2021
@jannfis jannfis merged commit ab7f7f1 into argoproj-labs:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants