-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth support. It is need for access to Azure CR #224
base: master
Are you sure you want to change the base?
Conversation
Hey @vikborisov, thanks for this PR. However, I feel that we should not move to yet another fork of Once this is done, please feel free to submit any changes required to make oAuth work. |
@jannfis Can you make a fork and i create a PR with my changes? |
Me moved away from |
Any updates on this? |
@andloh We're using version 0.10.1 with Azure Container Registry and it works fine so far. registries:
- name: youracrname
ping: yes
api_url: https://youracrname.azurecr.io
prefix: youracrname.azurecr.io
credentials: [...]
If this does not help you: Either we discuss your problem here or maybe create an issue 😉 |
Hi, thanks @janpieper. What du you use for authentication? SP, MSI, Token, Access Keys etc... Also...is it possible to use the integrated ACR -> AKS authentication? E.g the /etc/kubernetes/azure.conf |
Service Principal |
@janpieper i have been struggling with this for sometime. i'm using service principal but having authentication issues. i'm using the same ACR secret config for image pull in my deployments and it works flawlessly. but same ACR secret config doesn't work for argocd image updater. below are samples of my configs; --ApplicationSet-- apiVersion: argoproj.io/v1alpha1
---Image Updater Configmap--- apiVersion: v1 Help will really be appreciated. |
We also forked the nokia repo and fixed the OAuth contract.
Image Updater gets support for Azure CR