Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(registries): add env example #555

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

vsychov
Copy link
Contributor

@vsychov vsychov commented Apr 14, 2023

Docs lacks an example of the credentials environment variable, making it unclear whether it should contain dockerconfig, a login:password pair, or something else.
This Pull Request aims to address this issue by providing the necessary example.

Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for improving the docs!

@jannfis jannfis merged commit f61ddb4 into argoproj-labs:master Jun 8, 2023
8 of 9 checks passed
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants