-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dockerfile to pass builds #700
fix dockerfile to pass builds #700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 22 22
Lines 2150 2150
=======================================
Hits 1425 1425
Misses 591 591
Partials 134 134 ☔ View full report in Codecov by Sentry. |
d497cac
to
1e1a801
Compare
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
1e1a801
to
17e85b7
Compare
I was also hitting the following error when running the
Installing the |
@aburan28 why the version upgrade |
@chengfang reverted the change for miracl conflate. likely related to a unintended previous change when attemping updating go to 1.22 |
Just fyi, the lint CI failures (not related to this PR) will need to be fixed (see issue #706 ) to meet the merge requirements. I'll look into it. |
@aburan28 Can you rebase, squash, and add DCO (currently failing)? The lint error has been fixed earlier. |
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
14ccbab
to
b229f1b
Compare
@chengfang updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* updates to dockerfile Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.22 Signed-off-by: Adam Buran <aburan28@gmail.com> * update golangci-lint version Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.20 Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.20 Signed-off-by: Adam Buran <aburan28@gmail.com> * revert miracl conflate change w signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * Update go.sum with signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * Update go.sum with signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * revert miracl conflate version change Signed-off-by: Adam Buran <aburan28@gmail.com> * fix configurations of golangci-lint Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> * fix path Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com> * add signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites pt3 Signed-off-by: Adam Buran <aburan28@gmail.com> --------- Signed-off-by: Adam Buran <aburan28@gmail.com> Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com> Co-authored-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> Co-authored-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
* updates to dockerfile Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * update go to 1.21 Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.22 Signed-off-by: Adam Buran <aburan28@gmail.com> * update golangci-lint version Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.20 Signed-off-by: Adam Buran <aburan28@gmail.com> * lets go to 1.20 Signed-off-by: Adam Buran <aburan28@gmail.com> * revert miracl conflate change w signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * Update go.sum with signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * Update go.sum with signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * revert miracl conflate version change Signed-off-by: Adam Buran <aburan28@gmail.com> * fix configurations of golangci-lint Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> * fix path Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com> * add signoff Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites Signed-off-by: Adam Buran <aburan28@gmail.com> * vscode overwrites pt3 Signed-off-by: Adam Buran <aburan28@gmail.com> --------- Signed-off-by: Adam Buran <aburan28@gmail.com> Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com> Co-authored-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com> Co-authored-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
No description provided.