Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dockerfile to pass builds #700

Merged

Conversation

aburan28
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (7d93c7a) to head (ed93252).

❗ Current head ed93252 differs from pull request most recent head 6f47ce1. Consider uploading reports for the commit 6f47ce1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files          22       22           
  Lines        2150     2150           
=======================================
  Hits         1425     1425           
  Misses        591      591           
  Partials      134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aburan28 aburan28 force-pushed the adam--update-image-updater-dockerfile branch from d497cac to 1e1a801 Compare April 13, 2024 19:13
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
@aburan28 aburan28 force-pushed the adam--update-image-updater-dockerfile branch from 1e1a801 to 17e85b7 Compare April 13, 2024 19:15
@bebosudo
Copy link

bebosudo commented Apr 26, 2024

I was also hitting the following error when running the pip install --upgrade pip step:

error: externally-managed-environment

× This environment is externally managed
╰─> 
    The system-wide python installation should be maintained using the system
    package manager (apk) only.
    
    If the package in question is not packaged already (and hence installable via
    "apk add py3-somepackage"), please consider installing it inside a virtual
    environment, e.g.:
    
    python3 -m venv /path/to/venv
    . /path/to/venv/bin/activate
    pip install mypackage
    
    To exit the virtual environment, run:
    
    deactivate
    
    The virtual environment is not deleted, and can be re-entered by re-sourcing
    the activate file.
    
    To automatically manage virtual environments, consider using pipx (from the
    pipx package).

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

Installing the aws-cli package from apk instead of using pip solved my problem too.
Oddly, the container size increased from 237MB to 271MB after doing that though, probably because the apk package pulls some more dependencies in compared to pip.

@chengfang
Copy link
Collaborator

@aburan28 why the version upgrade github.com/miracl/conflate? Is it required fixing the error: externally-managed-environment problem?

@chengfang chengfang mentioned this pull request May 1, 2024
@aburan28
Copy link
Contributor Author

aburan28 commented May 2, 2024

@chengfang reverted the change for miracl conflate. likely related to a unintended previous change when attemping updating go to 1.22

@Ileriayo
Copy link
Contributor

Ileriayo commented May 3, 2024

Just curious.
The image currently has v1 of the awscli baked in, does this PR update it to v2?

image

@chengfang
Copy link
Collaborator

Just fyi, the lint CI failures (not related to this PR) will need to be fixed (see issue #706 ) to meet the merge requirements. I'll look into it.

@chengfang chengfang mentioned this pull request May 7, 2024
@chengfang
Copy link
Collaborator

@aburan28 Can you rebase, squash, and add DCO (currently failing)? The lint error has been fixed earlier.

aburan28 and others added 9 commits May 8, 2024 10:42
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
@aburan28 aburan28 force-pushed the adam--update-image-updater-dockerfile branch from 14ccbab to b229f1b Compare May 8, 2024 17:43
@aburan28
Copy link
Contributor Author

aburan28 commented May 8, 2024

@chengfang updated

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 29f4fb3 into argoproj-labs:master May 9, 2024
10 checks passed
burnb pushed a commit to burnb/argocd-image-updater that referenced this pull request May 23, 2024
* updates to dockerfile

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.22

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update golangci-lint version

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.20

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.20

Signed-off-by: Adam Buran <aburan28@gmail.com>

* revert miracl conflate change w signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* Update go.sum with signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* Update go.sum with signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* revert miracl conflate version change

Signed-off-by: Adam Buran <aburan28@gmail.com>

* fix configurations of golangci-lint

Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>

* fix path

Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>

* add signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites pt3

Signed-off-by: Adam Buran <aburan28@gmail.com>

---------

Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
Co-authored-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Co-authored-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
burnb pushed a commit to burnb/argocd-image-updater that referenced this pull request May 23, 2024
* updates to dockerfile

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update go to 1.21

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.22

Signed-off-by: Adam Buran <aburan28@gmail.com>

* update golangci-lint version

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.20

Signed-off-by: Adam Buran <aburan28@gmail.com>

* lets go to 1.20

Signed-off-by: Adam Buran <aburan28@gmail.com>

* revert miracl conflate change w signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* Update go.sum with signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* Update go.sum with signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* revert miracl conflate version change

Signed-off-by: Adam Buran <aburan28@gmail.com>

* fix configurations of golangci-lint

Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>

* fix path

Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>

* add signoff

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites

Signed-off-by: Adam Buran <aburan28@gmail.com>

* vscode overwrites pt3

Signed-off-by: Adam Buran <aburan28@gmail.com>

---------

Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
Co-authored-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
Co-authored-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants