-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: golangci lint #707
Fix: golangci lint #707
Conversation
0fbfb3a
to
206de6d
Compare
Dockerfile
Outdated
apk add ca-certificates git openssh-client python3 py3-pip tini && \ | ||
apk add --no-cache ca-certificates git openssh-client python3 py3-pip tini && \ | ||
python3 -m venv /venv && \ | ||
. /venv/bin/activate && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#700 already has a fix for the above problem in Dockerfile. I think we should treat this as a separate issue to be addressed by #700. If you agree, can you please undo this change in Dockerfile, and keep this PR for fixing lint? @0luwaj0x1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
@0luwaj0x1 can you also squash all commits? |
Signed-off-by: Josiah Ilesanmi <ilesanmi.josiah@gmail.com>
206de6d
to
82b5f6b
Compare
Thanks @0luwaj0x1 ! |
This PR fixes Issue #706