Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot #775

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

JunHyungJang
Copy link
Contributor

@JunHyungJang JunHyungJang commented Jul 14, 2024

This is my first attempt to contribute open sources.

I add the dependabot.yml file following this repo https://github.com/argoproj/argo-cd/blob/master/.github/dependabot.yml

Is there anything else I should add?

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (24f6815) to head (845a5ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files          31       31           
  Lines        3124     3124           
=======================================
  Hits         2124     2124           
  Misses        856      856           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
@chengfang
Copy link
Collaborator

@JunHyungJang since the reference dependabot config is from a different project (argo-cd), we'll need to adjust it for this project, e.g., in subdirectories and their package-ecosystem. As mentioned in the related issue, I think we can go with longer update interval to avoid too frequent updates: weekly or even monthly should be fine.

Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
@JunHyungJang
Copy link
Contributor Author

@chengfang I recognize what you said. Received feedbacks, I changed the interval. I also track the dockerfile and add the package-ecosystem to the right directories.

@chengfang chengfang merged commit 7a515c6 into argoproj-labs:master Jul 16, 2024
10 checks passed
@chengfang
Copy link
Collaborator

@JunHyungJang thanks!

@injae-kim
Copy link

Nice work @JunHyungJang !

sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Signed-off-by: junhyungjang <jsy3535@dgist.ac.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dependabot
4 participants