Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

fix: improve settings parsing errors #84

Merged

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 6, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #84 into master will decrease coverage by 1.18%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   53.66%   52.48%   -1.19%     
==========================================
  Files          24       24              
  Lines        1295     1347      +52     
==========================================
+ Hits          695      707      +12     
- Misses        497      534      +37     
- Partials      103      106       +3     
Impacted Files Coverage Δ
triggers/triggers.go 67.24% <56.25%> (-1.57%) ⬇️
notifiers/webhook.go 70.45% <0.00%> (-0.60%) ⬇️
notifiers/grafana.go 0.00% <0.00%> (ø)
notifiers/opsgenie.go 0.00% <0.00%> (ø)
notifiers/slack.go 22.80% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deb181...f38c084. Read the comment docs.

@alexmt alexmt merged commit 2c858e9 into argoproj-labs:master May 6, 2020
@alexmt alexmt deleted the improve-settings-parsing-errors branch May 6, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant