chore: cleanup reconcilation of roles, role bindings, service accounts #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishitasequeira
force-pushed
the
cleanup-roles-rb-sa
branch
from
13f215d
to
cfded8c
Compare
|
LGTM, thanks @ishitasequeira ! |
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira
force-pushed
the
cleanup-roles-rb-sa
branch
from
cfded8c
to
561f26d
Compare
ishitasequeira
force-pushed
the
cleanup-roles-rb-sa
branch
from
25c0de3
to
ea9302b
Compare
iam-veeramalla
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
LGTM, Thanks @ishitasequeira
Just a suggestion, going forward can you please update the PR with fields like
What does this PR do / why we need it:
How to test the changes
I can see that you have provided the JIRA ticket (which has details) but I don't mind duplication :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ishitasequeira ishiseq29@gmail.com
What type of PR is this?
/kind chore
What does this PR do / why we need it:
The reconciliation logic for Roles, Role Bindings and Service Accounts is confusing and has a lot of redundant code. This PR tries to cleanup the reconciliation logic and reduce number of calls to API server.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #? GITOPS-1854
How to test changes / Special notes to the reviewer:
Execute below commands on separate windows of terminal