New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor readme tweaks #46
Conversation
The readme assumes that the value in vault is a base64-encoded string, but most importantly doesn't actually say that anywhere. Using StringData instead of data allows the user to have a non-encoded string and this will still work.
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 42.92% 42.92%
=======================================
Files 13 13
Lines 403 403
=======================================
Hits 173 173
Misses 208 208
Partials 22 22 Continue to review full report at Codecov.
|
This reverts commit ac31455.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one small comment, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
I hit a few issues and inconsistencies with the readme when trying to get this set up, so here are some tweaks to hopefully clarify things for future users
Checklist
Please make sure that your PR fulfills the following requirements:
Type of Change
Other information