Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor readme tweaks #46

Merged
merged 8 commits into from
Feb 4, 2021
Merged

Minor readme tweaks #46

merged 8 commits into from
Feb 4, 2021

Commits on Feb 4, 2021

  1. Incorrect path to vault token in readme

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9e40c6b View commit details
    Browse the repository at this point in the history

  2. Readme typo

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    82df23c View commit details
    Browse the repository at this point in the history

  3. Use latest plugin version

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    db54d01 View commit details
    Browse the repository at this point in the history

  4. Correct location of vault token

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8c98c6c View commit details
    Browse the repository at this point in the history

  5. If you don't use stringData, this won't work 

    The readme assumes that the value in vault is a base64-encoded string, but most importantly doesn't actually say that anywhere. Using StringData instead of data allows the user to have a non-encoded string and this will still work.
    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ac31455 View commit details
    Browse the repository at this point in the history

  6. Revert "If you don't use stringData, this won't work" 

    This reverts commit ac31455.
    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1e46476 View commit details
    Browse the repository at this point in the history

  7. Update README.md

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    0fd499d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into main

    @tico24
    tico24 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1a3c360 View commit details
    Browse the repository at this point in the history