Prevent permanent diff on argocd_cluster with sensitive attributes
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onematchfox
commented
Jun 7, 2023
| } | ||
|
|
||
| if stateClusterConfig, ok := d.GetOk("config"); ok { | ||
| scc := expandClusterConfig(stateClusterConfig.([]interface{})[0]) |
There was a problem hiding this comment.
Rather than expanding the existing state as was done previously, this change makes use of the TLSClientConfig that is returned by the API, which ensures that we track the remote state of the attributes the API does return (I.e. CAData, CertData, Insecure and ServerName).
onematchfox
changed the title
argocd_cluster with sensitive attributes
oboukili
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the
argocd_clusterresource won't perma-diff on sensitive attributes whilst, at the same time, ensuring that we track the remote state for non-sensitive attributes that are returned by the API (see comment inline).Closes #297