Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value #70

Closed
jgwest opened this issue Dec 9, 2020 · 0 comments · Fixed by #109
Closed

The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value #70

jgwest opened this issue Dec 9, 2020 · 0 comments · Fixed by #109
Assignees
@jgwest
Labels
bug Something isn't working
Milestone
0.1.0 - Milestone 1

Comments

@jgwest
Copy link
Member

jgwest commented Dec 9, 2020 •
edited

At present the --namespace controller parameter in main.go, and the NAMESPACE environment variable in main.go control different values:

  • The --namespace param is passed to git generator
  • The NAMESPACE is passed to cache.MultiNamespacedCacheBuilder

So:

  • If both param and env are specified, one of them should override the other.
  • That one value should then be used for both the git generator and the cache

ALSO: Need to update the Readme.md with this PR.
@jgwest jgwest changed the title The --namespace controller param and NAMESPACE environment variable should override one another The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value Dec 9, 2020
@jgwest jgwest added the bug Something isn't working label Jan 12, 2021
@jgwest jgwest added this to the Milestone 1 milestone Jan 12, 2021
jgwest added a commit to jgwest/applicationset that referenced this issue Jan 21, 2021
@jgwest
The --namespace controller param and NAMESPACE environment variable s…
b90e15c 
…hould override to produce one canonical value (argoproj#70)
@jgwest jgwest self-assigned this Jan 21, 2021
@jgwest jgwest mentioned this issue Jan 26, 2021
Merged
jgwest added a commit to jgwest/applicationset that referenced this issue Jan 28, 2021
@jgwest
The --namespace controller param and NAMESPACE environment variable s…
574cf0f 
…hould override to produce one canonical value (argoproj#70)
@jgwest jgwest mentioned this issue Jan 28, 2021
Merged
jgwest added a commit to jgwest/applicationset that referenced this issue Jan 28, 2021
@jgwest
The --namespace controller param and NAMESPACE environment variable s…
33c032b 
…hould override to produce one canonical value (argoproj#70)
xianlubird pushed a commit that referenced this issue Jan 29, 2021
@jgwest
The --namespace controller param and NAMESPACE environment variable s…
9295445 
…hould override to produce one canonical value (#70) (#109)

* The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value (#70)

* The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value (#70)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jgwest jgwest

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0 - Milestone 1
1 participant
@jgwest