This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
The --namespace controller param and NAMESPACE environment variable should override to produce one canonical value (#70) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould override to produce one canonical value (argoproj#70)
OmerKahani
reviewed
Jan 28, 2021
main.go
Outdated
| } | ||
| setupLog.Info("using argocd namespace", "namespace", ns) | ||
|
|
||
| setupLog.Info("Using argocd namespace", "namespace", namespace) |
There was a problem hiding this comment.
The log might be misleading if the namespace is not argocd
…hould override to produce one canonical value (argoproj#70)
OmerKahani
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
As described on the issue, fix is to use the namespace value specified in this order (top is highest):