This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Git Directory Generator only matches directories that contain valid Helm/ksonnet/Kustomize artifacts #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmerKahani
reviewed
Feb 27, 2021
…elm/ksonnet/Kustomize artifacts
…elm/ksonnet/Kustomize artifacts
…elm/ksonnet/Kustomize artifacts
…elm/ksonnet/Kustomize artifacts
…elm/ksonnet/Kustomize artifacts
jgwest
force-pushed
the
git-only-valid-apps-121
branch
from
47f78e7
to
8b94650
Compare
wtam2018
reviewed
Mar 1, 2021
…elm/ksonnet/Kustomize artifacts
wtam2018
reviewed
Mar 1, 2021
|
|
||
| repoRoot := gitRepoClient.Root() | ||
|
|
||
| if err := filepath.Walk(repoRoot, func(path string, info os.FileInfo, fnErr error) error { |
There was a problem hiding this comment.
Have you considered calling LsFiles and then use filepath.Base() to only keep directores? We won't have to explictly skip "." and .git.
There was a problem hiding this comment.
@wtam2018 - Good thinking, and actually I tried this approach first: the problem is that LsFiles doesn't list directories, only files, and there doesn't seem to be a switch to enable it show directories (see man git-ls-files). LsFiles is just a minimal wrapper around the git ls-files --full-name -- (path to repo) command, which you can try yourself on a local repo to see that it only lists files.
wtam2018
approved these changes
Mar 1, 2021
OmerKahani
approved these changes
Mar 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See parent issue for details.
Fixes #121