This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
Git Directory Generator only matches directories that contain valid Helm/ksonnet/Kustomize artifacts #132
Merged
Merged
Git Directory Generator only matches directories that contain valid Helm/ksonnet/Kustomize artifacts #132
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9b54f0e
Git Directory Generator only matches directories that contain valid H…
jgwest 766d993
Git Directory Generator only matches directories that contain valid H…
jgwest f10a1ba
Git Directory Generator only matches directories that contain valid H…
jgwest b36f170
Git Directory Generator only matches directories that contain valid H…
jgwest 8b94650
Git Directory Generator only matches directories that contain valid H…
jgwest 44ec678
Git Directory Generator only matches directories that contain valid H…
jgwest File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered calling
LsFiles
and then use filepath.Base() to only keep directores? We won't have to explictly skip "." and .git.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtam2018 - Good thinking, and actually I tried this approach first: the problem is that
LsFiles
doesn't list directories, only files, and there doesn't seem to be a switch to enable it show directories (seeman git-ls-files
).LsFiles
is just a minimal wrapper around thegit ls-files --full-name -- (path to repo)
command, which you can try yourself on a local repo to see that it only lists files.