This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
fix: downgrade Argo CD dependency to exclude argoproj/argocd#ca2e3041 #533
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
requested review from
jgwest and
crenshaw-dev
and removed request for
jgwest
jgwest
pushed a commit
that referenced
this pull request
Mar 10, 2022
…#533) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
The argoproj/argo-cd#8516 introduced an incompatible change in Argo CD that changes how repo credentials are passed to git. In order to accommodate this change, we would have to add
argocdbinary into applicationset image. This is too intrusive change, especially since we agreed to merge applicationset and argocd code.So I propose to temporary use pre v2.3 release version of Argo CD that does not have argoproj/argo-cd#8516 and prioritize merging Application + Argo CD during v2.4 Argo CD .