This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
kubebuilder 2 #93
Merged
kubebuilder 2 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoodness
force-pushed
the
kubebuilder-2
branch
2 times, most recently
from
73c8443
to
d1113ba
Compare
OmerKahani
approved these changes
Jan 12, 2021
This was referenced Jan 13, 2021
mgoodness
force-pushed
the
kubebuilder-2
branch
4 times, most recently
from
b2ea4f2
to
f6074eb
Compare
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
mgoodness
force-pushed
the
kubebuilder-2
branch
from
f6074eb
to
72d79f8
Compare
wtam2018
reviewed
Jan 13, 2021
Co-authored-by: William Tam <wtam@redhat.com>
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
mgoodness
force-pushed
the
kubebuilder-2
branch
from
1b721fd
to
8056c5d
Compare
mgoodness
commented
Jan 13, 2021
Signed-off-by: Michael Goodness <michael.goodness@mlb.com>
|
/LGTM |
|
@mgoodness, I merged #96. Do you need to test your branch with it, or is it good to go? |
Good to go! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a re-bootstrap of the project using kubebuilder 2, pulling in changes that have been made upstream since June. I also made opportunistic fixes - mostly to address linting errors. The biggest change is that the ApplicationSet CRD has been re-generated to support the latest version of the Argo CD Application API. It also presents an opportunity to move to
github.com/go-logr/logrfromgithub.com/sirupsen/logrussince that's what controller-runtime now uses.Depends on #96