This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Intermittent test failure in 'TestGitGenerateParamsFromFiles/handles_error_during_getting_repo_file_contents' #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoodness
approved these changes
Jan 13, 2021
|
/LGTM |
OmerKahani
reviewed
Jan 13, 2021
Merged
OmerKahani
approved these changes
Jan 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failure was due to differing ordering of entries within a map between test runs; the fix is to use
assert.ElementsMatch(...)as suggested by @mgoodness, plus ensuring a deterministic ordering in the order in which paths are processed by the generator (which end users of the generator should find to be a preferable behaviour).Parent issue #92