Skip to content

Commit

Permalink
Merge branch 'master' into oci-versions
Browse files Browse the repository at this point in the history
  • Loading branch information
alexef committed Oct 5, 2022
2 parents 60c05e4 + 214b980 commit 32eb41b
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ jobs:
git config --global user.email "john.doe@example.com"
- name: Pull Docker image required for tests
run: |
docker pull ghcr.io/dexidp/dex:v2.35.0-distroless
docker pull ghcr.io/dexidp/dex:v2.35.1-distroless
docker pull argoproj/argo-cd-ci-builder:v1.0.0
docker pull redis:7.0.5-alpine
- name: Create target directory for binaries in the build-process
Expand Down
19 changes: 19 additions & 0 deletions docs/user-guide/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ argocd app set helm-guestbook --values values-production.yaml
location in which case it can be accessed using a relative path relative to the root directory of
the Helm chart.

In the declarative syntax:

```yaml
source:
helm:
valueFiles:
- values-production.yaml
```

## Helm Parameters

Helm has the ability to set parameter values, which override any values in
Expand All @@ -53,6 +62,16 @@ in the form of `-p PARAM=VALUE`. For example:
argocd app set helm-guestbook -p service.type=LoadBalancer
```

In the declarative syntax:

```yaml
source:
helm:
parameters:
- name: "service.type"
value: LoadBalancer
```

## Helm Release Name

By default, the Helm release name is equal to the Application name to which it belongs. Sometimes, especially on a centralised ArgoCD,
Expand Down
2 changes: 1 addition & 1 deletion manifests/base/dex/argocd-dex-server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
type: RuntimeDefault
containers:
- name: dex
image: ghcr.io/dexidp/dex:v2.35.0-distroless
image: ghcr.io/dexidp/dex:v2.35.1-distroless
imagePullPolicy: Always
command: [/shared/argocd-dex, rundex]
env:
Expand Down
2 changes: 1 addition & 1 deletion manifests/ha/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10962,7 +10962,7 @@ spec:
key: dexserver.disable.tls
name: argocd-cmd-params-cm
optional: true
image: ghcr.io/dexidp/dex:v2.35.0-distroless
image: ghcr.io/dexidp/dex:v2.35.1-distroless
imagePullPolicy: Always
name: dex
ports:
Expand Down
2 changes: 1 addition & 1 deletion manifests/ha/namespace-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1631,7 +1631,7 @@ spec:
key: dexserver.disable.tls
name: argocd-cmd-params-cm
optional: true
image: ghcr.io/dexidp/dex:v2.35.0-distroless
image: ghcr.io/dexidp/dex:v2.35.1-distroless
imagePullPolicy: Always
name: dex
ports:
Expand Down
2 changes: 1 addition & 1 deletion manifests/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10033,7 +10033,7 @@ spec:
key: dexserver.disable.tls
name: argocd-cmd-params-cm
optional: true
image: ghcr.io/dexidp/dex:v2.35.0-distroless
image: ghcr.io/dexidp/dex:v2.35.1-distroless
imagePullPolicy: Always
name: dex
ports:
Expand Down
2 changes: 1 addition & 1 deletion manifests/namespace-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ spec:
key: dexserver.disable.tls
name: argocd-cmd-params-cm
optional: true
image: ghcr.io/dexidp/dex:v2.35.0-distroless
image: ghcr.io/dexidp/dex:v2.35.1-distroless
imagePullPolicy: Always
name: dex
ports:
Expand Down
2 changes: 0 additions & 2 deletions util/settings/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -749,9 +749,7 @@ func (mgr *SettingsManager) GetResourceOverrides() (map[string]v1alpha1.Resource
switch diffOptions.IgnoreResourceStatusField {
case "", "crd":
addStatusOverrideToGK(resourceOverrides, crdGK)
log.Info("Ignore status for CustomResourceDefinitions")
addIgnoreDiffItemOverrideToGK(resourceOverrides, crdGK, crdPrsvUnkn)
log.Infof("Ignore '%v' for CustomResourceDefinitions", crdPrsvUnkn)
case "all":
addStatusOverrideToGK(resourceOverrides, "*/*")
log.Info("Ignore status for all objects")
Expand Down

0 comments on commit 32eb41b

Please sign in to comment.