chore: add logic to tell user if app was updated

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>

cmd/argocd/commands/app.go

@@ -163,14 +163,23 @@ func NewApplicationCreateCommand(clientOpts *argocdclient.ClientOptions) *cobra.
 					Validate:    &appOpts.Validate,
 				}
 
+				// Get app before creating to see if it is being updated or no change
+				existing, _ := appIf.Get(ctx, &applicationpkg.ApplicationQuery{Name: &app.Name})
+
 				created, err := appIf.Create(ctx, &appCreateRequest)
 				errors.CheckError(err)
 
-				if !hasAppChanged(appCreateRequest.Application, created, upsert) {
-					fmt.Printf("application '%s' unchanged\n", created.ObjectMeta.Name)
+				var action string
+				// App created for first time if generation==1
+				if existing == nil {
+					action = "created"
+				} else if !hasAppChanged(existing, created, upsert) {
+					action = "unchanged"
 				} else {
-					fmt.Printf("application '%s' created\n", created.ObjectMeta.Name)
+					action = "updated"
 				}
+
+				fmt.Printf("application '%s' %s\n", created.ObjectMeta.Name, action)
 			}
 		},
 	}
@@ -217,6 +226,11 @@ func getRefreshType(refresh bool, hardRefresh bool) *string {
 }
 
 func hasAppChanged(appReq, appRes *argoappv1.Application, upsert bool) bool {
+	// upsert==false means no way change occurred from create command
+	if !upsert {
+		return false
+	}
+
 	// If no project, assume default project
 	if appReq.Spec.Project == "" {
 		appReq.Spec.Project = "default"
@@ -235,8 +249,7 @@ func hasAppChanged(appReq, appRes *argoappv1.Application, upsert bool) bool {
 	if reflect.DeepEqual(appRes.Spec, appReq.Spec) &&
 		reflect.DeepEqual(appRes.Labels, appReq.Labels) &&
 		reflect.DeepEqual(appRes.ObjectMeta.Annotations, appReq.Annotations) &&
-		reflect.DeepEqual(appRes.Finalizers, appReq.Finalizers) &&
-		!upsert {
+		reflect.DeepEqual(appRes.Finalizers, appReq.Finalizers) {
 		return false
 	}
 

cmd/argocd/commands/app_test.go

@@ -1171,6 +1171,7 @@ func Test_hasAppChanged(t *testing.T) {
 			args: args{
 				appReq: testApp("foo", "default", map[string]string{}, map[string]string{}, []string{}),
 				appRes: testApp("foo", "foo", nil, nil, nil),
+				upsert: true,
 			},
 			want: true,
 		},
@@ -1179,6 +1180,7 @@ func Test_hasAppChanged(t *testing.T) {
 			args: args{
 				appReq: testApp("foo", "default", map[string]string{"foo": "bar"}, map[string]string{"foo": "bar"}, []string{"foo"}),
 				appRes: testApp("foo", "default", map[string]string{"foo": "bar"}, map[string]string{"foo": "bar"}, []string{"foo"}),
+				upsert: true,
 			},
 			want: false,
 		},
@@ -1187,6 +1189,7 @@ func Test_hasAppChanged(t *testing.T) {
 			args: args{
 				appReq: testApp("foo", "default", map[string]string{}, map[string]string{}, []string{}),
 				appRes: testApp("foo", "default", nil, nil, nil),
+				upsert: true,
 			},
 			want: false,
 		},
@@ -1199,13 +1202,13 @@ func Test_hasAppChanged(t *testing.T) {
 			want: false,
 		},
 		{
-			name: "App changed - From upsert",
+			name: "App unchanged - From upsert=false",
 			args: args{
 				appReq: testApp("foo", "foo", map[string]string{}, map[string]string{}, []string{}),
 				appRes: testApp("foo", "default", nil, nil, nil),
-				upsert: true,
+				upsert: false,
 			},
-			want: true,
+			want: false,
 		},
 	}
 	for _, tt := range tests {